Skip to content

Conversation

@vobradovich
Copy link
Member

No description provided.

@vobradovich vobradovich self-assigned this Nov 20, 2025
@vobradovich vobradovich marked this pull request as ready for review December 18, 2025 16:27
@vobradovich
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces serde serialization and deserialization for the IDL AST, which is a great feature for interoperability. The implementation is mostly solid, using conditional compilation to make serde support optional.

I've left a few comments regarding the serde attributes:

  • There's a confusing and likely incorrect use of #[serde(untagged)] on an enum variant, which should be refactored for clarity and correctness.
  • There are some inconsistencies in handling empty Vec fields during serialization. Applying skip_serializing_if = "Vec::is_empty" uniformly would make the JSON output cleaner and more consistent.

Overall, this is a valuable addition. Addressing these points will improve the maintainability and robustness of the code.

@vobradovich vobradovich merged commit acfa105 into master-idl-v2 Jan 22, 2026
4 checks passed
@vobradovich vobradovich deleted the vo/idl-v2-serde branch January 22, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants